Messages in this thread | | | Date | Sun, 6 Jul 2008 02:12:27 +0200 | From | "Miguel Ojeda" <> | Subject | Re: [PATCH] auxdisplay: small cleanups |
| |
On Sat, Jul 5, 2008 at 1:21 PM, Akinobu Mita <akinobu.mita@gmail.com> wrote: > - Use BUILD_BUG_ON for CFAG12864B_SIZE instead of runtime-check > > - Use get_zeroed_page()
Thank you very much! I will test it soon (~10th of July). In the meantime:
Signed-off-by: Miguel Ojeda Sandonis <maxextreme@gmail.com>
> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > Cc: Miguel Ojeda Sandonis <maxextreme@gmail.com> > --- > drivers/auxdisplay/cfag12864b.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > Index: 2.6-git/drivers/auxdisplay/cfag12864b.c > =================================================================== > --- 2.6-git.orig/drivers/auxdisplay/cfag12864b.c > +++ 2.6-git/drivers/auxdisplay/cfag12864b.c > @@ -336,16 +336,9 @@ static int __init cfag12864b_init(void) > "ks0108 is not initialized\n"); > goto none; > } > + BUILD_BUG_ON(PAGE_SIZE < CFAG12864B_SIZE); > > - if (PAGE_SIZE < CFAG12864B_SIZE) { > - printk(KERN_ERR CFAG12864B_NAME ": ERROR: " > - "page size (%i) < cfag12864b size (%i)\n", > - (unsigned int)PAGE_SIZE, CFAG12864B_SIZE); > - ret = -ENOMEM; > - goto none; > - } > - > - cfag12864b_buffer = (unsigned char *) __get_free_page(GFP_KERNEL); > + cfag12864b_buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL); > if (cfag12864b_buffer == NULL) { > printk(KERN_ERR CFAG12864B_NAME ": ERROR: " > "can't get a free page\n"); > @@ -367,8 +360,6 @@ static int __init cfag12864b_init(void) > if (cfag12864b_workqueue == NULL) > goto cachealloced; > > - memset(cfag12864b_buffer, 0, CFAG12864B_SIZE); > - > cfag12864b_clear(); > cfag12864b_on(); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
| |