Messages in this thread | | | Subject | RE: [PATCH 2/2 V2] MMC: cleanup endianity conversions and style problems | Date | Sun, 6 Jul 2008 02:54:56 +0300 | From | "Winkler, Tomas" <> |
| |
>-----Original Message----- >From: Pierre Ossman [mailto:drzeus-list@drzeus.cx] >Sent: Sunday, July 06, 2008 2:27 AM >To: Winkler, Tomas >Cc: marcel@holtmann.org; linux-kernel@vger.kernel.org; Winkler, Tomas >Subject: Re: [PATCH 2/2 V2] MMC: cleanup endianity conversions and style >problems > >On Sat, 5 Jul 2008 19:52:05 +0300 >Tomas Winkler <tomas.winkler@intel.com> wrote: > >> This patch cleans up endianity conversions im mmc core >> and style errors in the 'for' statements >> >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> >> --- > >NAK in its current form. The data needs to be DMA:able, which means >that the stack cannot be used. > I see, anyway only the last hunk is problematic in this matter.
So we need to define raw_src as __be32 and translate it in mmc_decode_src I will get to the MMC spec only tomorrow but it sound strange that SDIO registers are in little endian and these are in big. Thanks Tomas
--------------------------------------------------------------------- Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
| |