lkml.org 
[lkml]   [2008]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for July 30
On Thu, 31 Jul 2008 15:42:07 -0400
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> - return bits_to_user(bits, len, _IOC_SIZE(cmd), p, compat_mode);
> +
> + if ((_IOC_NR(cmd) & EV_MAX) == EV_KEY && buf_len == 0x1ff) {
> + printk(KERN_WARNING
> + "evdev.c(EVIOCGBIT): Detected suspicious "
> + "buffer size 0x1ff, limiting output to 64 "
> + "bytes. Make sure you are not using "
> + "EVIOCGBIT(EV_KEY, KEY_MAX)\n");
> + buf_len = 64;
> + }

If that works then great. But I think the printk could be improved.
Please provide sufficient information so that users (not programmers)
can go off and fix things up without needing to email kernel developers.

One suitable approach would be

printk("see http://userweb.kernel.org/~dtor/read-this.txt")



\
 
 \ /
  Last update: 2008-07-31 22:15    [W:0.130 / U:18.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site