lkml.org 
[lkml]   [2008]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: change remove NR_IRQS in 8250.c
On Thu, Jul 31, 2008 at 4:50 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
>> replace
>> [PATCH] serial: change irq_lists to use dyn_array
>> use small array with index to handle irq locking for serial port
>> hope 32 slot is enough
>
> Could you size this array by NR_UARTS (our worst case usage)

how about crazy user set that too big?

> and place irq_no in struct irq_info?
should be ok
>
> Also you want to hold irq_info->lock when you set or clear irq_no.
> Just to be on the safe side. I expect we can avoid clearing the irq_no
> in the irq_lists and prevent a few more races from being a possibility.

will try

YH


\
 
 \ /
  Last update: 2008-08-01 05:23    [from the cache]
©2003-2011 Jasper Spaans