lkml.org 
[lkml]   [2008]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 0/9] x86, xsave: xsave/xrstor support


On Thu, 31 Jul 2008, Suresh Siddha wrote:
> On Thu, Jul 31, 2008 at 03:14:35PM -0700, Andi Kleen wrote:
> > > Kernel was enabling watchdog, with out the userspace having the
> > > heartbeat daemon....
> >
> > Watchdog are normally only armed when someone opens the device
> > first.
>
> But thats not what I see with for ex with, w83627hf_wdt.c
>
> Its done at the module_init time. (while I thought it should be
> really done when some user level app opens the device, probably
> its poorly written to take care if the kernel panics before starting userland.
> but kernel can even die before the watchdog driver load aswell ;-)

Yeah, that's a _really_ broken watchdog timer driver. There's no way that
it's correct to start the watchdog at init time, at least when compiled
in.

It also looks to me like it's not even probing for the hardware - it's
just assuming it's there. That's scary. Am I missing something?

It really shouldn't be activated until it's opened. And it really
shouldn't just write to ports randomly without checking that they make
sense...

Linus


\
 
 \ /
  Last update: 2008-08-01 00:45    [from the cache]
©2003-2011 Jasper Spaans