Messages in this thread | | | Date | Wed, 30 Jul 2008 23:51:43 -0400 | From | "Mike Frysinger" <> | Subject | Re: [PATCH] blackfin / h8300 build error fix |
| |
On Wed, Jul 30, 2008 at 11:37 PM, Andrew Morton wrote: > On Wed, 30 Jul 2008 23:26:47 -0400 "Mike Frysinger" wrote: >> you cant just use straight symbol names in common header files as they >> dont take into consideration weird arch-specific ABI conventions. in >> the case of Blackfin/h8300, the ABI dictates that any C-visible >> symbols have an underscore prefixed to them. thus all symbols in >> vmlinux.lds.h need to be wrapped in VMLINUX_SYMBOL() so that each arch >> can put hide this magic in their own files. > > ooh, a changelog. > > This seems to be a pretty common failing. I just had to fix the same > problem in a linux-next patch:
PERCPU is broken in mainline currently as well ... but it looks like there's extended stuff in linux-next now
> It's going to keep happening too, unless we find some way of making x86 > break when people forget to use VMLINUX_SYMBOL().
i pondered it briefly when i saw Yoshinori's original e-mail, but nothing pretty came to mind -mike
| |