lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 60/62] b43legacy: Release mutex in error handling code
    2.6.26 -stable review patch.  If anyone has any objections, please let
    us know.

    ------------------
    From: Julia Lawall <julia@diku.dk>

    commit 4104863fb4a724723d1d5f3cba9d3c5084087e45 upstream

    The mutex is released on a successful return, so it would seem that it
    should be released on an error return as well.

    The semantic patch finds this problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    // <smpl>
    @@
    expression l;
    @@

    mutex_lock(l);
    .. when != mutex_unlock(l)
    when any
    when strict
    (
    if (...) { ... when != mutex_unlock(l)
    + mutex_unlock(l);
    return ...;
    }
    |
    mutex_unlock(l);
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>
    Signed-off-by: Michael Buesch <mb@bu3sch.de>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/wireless/b43legacy/main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/b43legacy/main.c
    +++ b/drivers/net/wireless/b43legacy/main.c
    @@ -3862,10 +3862,10 @@ static int b43legacy_resume(struct ssb_d
    goto out;
    }
    }
    - mutex_unlock(&wl->mutex);

    b43legacydbg(wl, "Device resumed.\n");
    out:
    + mutex_unlock(&wl->mutex);
    return err;
    }

    --


    \
     
     \ /
      Last update: 2008-07-31 02:33    [W:0.033 / U:19.720 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site