Messages in this thread | | | Date | Thu, 31 Jul 2008 10:21:54 +1000 | From | Stephen Rothwell <> | Subject | Re: [patch 00/19] perfmon2 minimal v3: introduction |
| |
Hi Stephane,
On Wed, 30 Jul 2008 16:59:34 -0700 "stephane eranian" <eranian@googlemail.com> wrote: > > On Mon, Jul 28, 2008 at 11:20 PM, stephane eranian > <eranian@googlemail.com> wrote: > >> quite a few of the macros (especially for the dummy (non > >> CONFIG_PERFMON) versions of functions) should be "static inline" > >> functions unless they absolutely must be macros. Andrew Morton said it > >> best - "write in C not C preprocessor". > >> > Do you also have a problem with the debug printk statements using macros?
Not really, they would be a pain to write as C code.
The advantage of using C code for the dummy versions of things is that we still get type checking and we eliminate "unused variable" warnings for parameters of the functions.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |