Messages in this thread Patch in this message | | | Date | Wed, 30 Jul 2008 16:27:38 -0700 | From | Greg KH <> | Subject | [patch 25/29] b43legacy: Release mutex in error handling code |
| |
2.6.25-stable review patch. If anyone has any objections, please let us know.
------------------ From: Julia Lawall <julia@diku.dk>
commit 4104863fb4a724723d1d5f3cba9d3c5084087e45 upstream
The mutex is released on a successful return, so it would seem that it should be released on an error return as well.
The semantic patch finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl> @@ expression l; @@
mutex_lock(l); .. when != mutex_unlock(l) when any when strict ( if (...) { ... when != mutex_unlock(l) + mutex_unlock(l); return ...; } | mutex_unlock(l); ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Michael Buesch <mb@bu3sch.de> Signed-off-by: John W. Linville <linville@tuxdriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/net/wireless/b43legacy/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/b43legacy/main.c +++ b/drivers/net/wireless/b43legacy/main.c @@ -3792,10 +3792,10 @@ static int b43legacy_resume(struct ssb_d goto out; } } - mutex_unlock(&wl->mutex); b43legacydbg(wl, "Device resumed.\n"); out: + mutex_unlock(&wl->mutex); return err; } --
| |