lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/3] kmsg: convert xpram messages to kmsg api.
On Wed, Jul 30, 2008 at 06:56:59PM +0200, Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> ---
>
> Documentation/kmsg/s390/xpram | 54 ++++++++++++++++++++++++++++++++++++++++++
> drivers/s390/block/xpram.c | 41 ++++++++++++++-----------------
> 2 files changed, 73 insertions(+), 22 deletions(-)
>
> Index: linux-2.6/Documentation/kmsg/s390/xpram
> ===================================================================
> --- /dev/null
> +++ linux-2.6/Documentation/kmsg/s390/xpram
> @@ -0,0 +1,54 @@
> +/*?
> + * Tag: xpram.1

Ick, so you are going to have to define a message number per file?
How is that going to work, it looks like you use ids 0-2 below in the .c
file, yet in this documentation file they are 1-3. Off by one
somewhere? :)

> + * Text: "%d is not a valid number of XPRAM devices"
> + * Severity: Error
> + * Parameter:
> + * @1: number of partitions
> + * Description:
> + * The number of XPRAM partitions specified for the 'devs' module parameter
> + * or with the 'xpram.parts' kernel parameter must be an integer in the
> + * range 1 to 32. The XPRAM device driver created a maximum of 32 partitions
> + * that are probably not configured as intended.
> + * User action:
> + * If the XPRAM device driver has been compiled as a separate module,
> + * unload the module and load it again with a correct value for the
> + * 'devs' module parameter. If the XPRAM device driver has been compiled
> + * into the kernel, correct the 'xpram.parts' parameter in the kernel
> + * parameter line and restart Linux.
> + */

Any way to put this stuff in the .c file itself? It's hard enough
getting people to update Documentation/ABI/, knowing to go modify
something else in the Documentation directory is going to be _very_
difficult.

>
> +#define KMSG_COMPONENT "xpram"

Can't you just use KBUILD_MODULE_NAME instead? That makes it one less
thing you have to define in the code (and forget about when moving files
around or cut-and-pasting).

> /* Check number of devices. */
> if (devs <= 0 || devs > XPRAM_MAX_DEVS) {
> - PRINT_ERR("invalid number %d of devices\n",devs);
> + kmsg_err(1, "%d is not a valid number of XPRAM devices\n",devs);
> return -EINVAL;

Magic number "1" here? See comment above about this.

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-07-30 21:55    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean