lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mISDN cleanup user interface
From
Date
On Wed, 2008-07-30 at 18:33 +0200, Karsten Keil wrote:
> What about this implementation ?

Looks a lot saner... although it does seem to confirm my earlier
suspicion that you're not even _using_ the fact that it's a bitmap at
all. You set the bits for the present channels at init time, which are
always contiguous, and you never seem to change them them later -- why
couldn't you do this with a simple 'number of channels' integer?

Are you later intending to use the bitmap to mark them as busy/free?

--
dwmw2



\
 
 \ /
  Last update: 2008-07-30 18:59    [from the cache]
©2003-2011 Jasper Spaans