Messages in this thread | | | Date | Wed, 30 Jul 2008 09:33:28 -0700 | From | Greg KH <> | Subject | Re: [PATCH] ide-cd: fix endianity for the error message in cdrom_read_capacity |
| |
On Wed, Jul 30, 2008 at 10:52:50AM +0200, Boris Petkov wrote: > On Wed, Jul 30, 2008 at 10:18 AM, Andrew Morton > <akpm@linux-foundation.org> wrote: > > On Wed, 30 Jul 2008 10:10:06 +0200 Petr Tesarik <ptesarik@suse.cz> wrote: > > > >> Resent because of a typo in the LKML address. :( > > > > Thanks. > > > >> > >> Aesthetic regards aside, commit e8e7b9eb11c34ee18bde8b7011af41938d1ad667 > >> still leaves a bug in the error message, because it uses the unconverted > >> big-endian value for printk. > >> > >> Fix this by using a local variable in machine byte order. The result is > >> correct, more readable, and also produces slightly shorter code on i386. > >> > >> Cc: Jens Axboe <jens.axboe@oracle.com> > >> Cc: Jan Kara <jack@suse.cz> > >> Signed-off-by: Petr Tesarik <ptesarik@suse.cz> > > I definitely like this one better, thanks. > > Acked-by: Borislav Petkov <petkovbb@gmail.com> > > > > > > Bart owns this patch now. It got lost for a month and it has already > > been fixed twice and it is also on the route to 2.6.25.x and 2.6.26.x, > > so it'll get complicated. Not a happy little patch. > > Greg, can you please apply this one on top of -stable.
What one? Do you have a git commit id?
And please, send stable requests to stable@kernel.org, otherwise they have a tendancy to get lost in my horrible inbox these days...
thanks,
greg k-h
| |