Messages in this thread | | | Date | Wed, 30 Jul 2008 08:43:35 -0700 | From | Tim Wright <> | Subject | Re: [PATCH] Fix miscalculation of sg_io timeout in CDROM_SEND_PACKET handler. |
| |
James Bottomley wrote: > On Sun, 2008-07-27 at 17:50 -0700, Tim Wright wrote: > >> @@ -629,7 +629,7 @@ int scsi_cmd_ioctl(struct file *file, st >> hdr.sbp = cgc.sense; >> if (hdr.sbp) >> hdr.mx_sb_len = sizeof(struct >> request_sense); >> - hdr.timeout = cgc.timeout; >> + hdr.timeout = jiffies_to_msecs(cgc.timeout); >> hdr.cmdp = ((struct cdrom_generic_command >> __user*) arg)->cmd; >> hdr.cmd_len = sizeof(cgc.cmd); >> > > I'm afraid this patch is completely whitespace damaged: the tabs have > all become spaces and the mailer has broken some of the lines. > > Since it's a one liner, I can make the fix directly, but if you look at > > Documentation/SubmittingPatches > > It has some good advice about how to fix your email tool to prevent this > from happening in future. > > James > > > Ugh, mea culpa! Thanks James. I haven't submitted anything in a while, and was using Thunderbird. I will go off and figure out how to make it leave the contents alone, or I'll use a less "clever" client in future. Many thanks for the response and the gentle coaching :-)
Regards,
Tim
| |