lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix miscalculation of sg_io timeout in CDROM_SEND_PACKET handler.
James Bottomley wrote:
> On Sun, 2008-07-27 at 17:50 -0700, Tim Wright wrote:
>
>> @@ -629,7 +629,7 @@ int scsi_cmd_ioctl(struct file *file, st
>> hdr.sbp = cgc.sense;
>> if (hdr.sbp)
>> hdr.mx_sb_len = sizeof(struct
>> request_sense);
>> - hdr.timeout = cgc.timeout;
>> + hdr.timeout = jiffies_to_msecs(cgc.timeout);
>> hdr.cmdp = ((struct cdrom_generic_command
>> __user*) arg)->cmd;
>> hdr.cmd_len = sizeof(cgc.cmd);
>>
>
> I'm afraid this patch is completely whitespace damaged: the tabs have
> all become spaces and the mailer has broken some of the lines.
>
> Since it's a one liner, I can make the fix directly, but if you look at
>
> Documentation/SubmittingPatches
>
> It has some good advice about how to fix your email tool to prevent this
> from happening in future.
>
> James
>
>
>
Ugh, mea culpa! Thanks James. I haven't submitted anything in a while,
and was using Thunderbird. I will
go off and figure out how to make it leave the contents alone, or I'll
use a less "clever" client in future.
Many thanks for the response and the gentle coaching :-)

Regards,

Tim



\
 
 \ /
  Last update: 2008-07-30 17:45    [W:0.042 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site