lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] add iommu_num_pages helper function
    From
    On Wed, 30 Jul 2008 14:18:05 +0200
    Joerg Roedel <joerg.roedel@amd.com> wrote:

    > On Tue, Jul 29, 2008 at 03:10:05AM -0700, David Miller wrote:
    > > From: Joerg Roedel <joerg.roedel@amd.com>
    > > Date: Tue, 29 Jul 2008 11:50:27 +0200
    > >
    > > > I think moving that function to x86-only code is the best solution for
    > > > now. Before moving it back to generic code we need an architecture
    > > > independent way to find out the IOMMU page size.
    > >
    > > My suggestion (again) is to pass it in as a "const unsigned long
    > > io_page_size" argument and update the callers.
    >
    > Ok, after setting up cross compile environments for sparc64 and
    > powerpc64 I wrote a patch which adds the io_page_size argument to the
    > iommu_num pages function and moves the function back to
    > lib/iommu-helper.c.

    You need ia64, parisc, and alpha too. :)

    I have cross compile environments for them so I can take care of them
    if you like.


    > The patch touches all 3 architectures and can not be
    > split in a bisectable way.

    How about naming a new helper function iommu_nr_pages (or something)?

    Then you can do the conversion independently. If we like, we use
    iommu_num_pages name after the conversion.


    > Who is the best person to send this patch to?

    The -mm is an appropriate tree, I think.


    \
     
     \ /
      Last update: 2008-07-30 15:19    [W:3.178 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site