lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC [PATCH] x86: introduce nr_irqs for 64bit
On Wed, Jul 30, 2008 at 3:09 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
>> add DEFINE_DYN_ARRAY for dynamical array support
>>
>> todo:
>> 1. convert x86 32bit and other arch
>> 2. nr_irqs auto probe via acpi_oem_check?
>>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> wonderful!
>
> I have one main structural suggestion: could we please keep the NR_IRQS
> name, and just change it to dynamic on x86? NR_IRQS is used in 540
> places in the kernel, there's no point in touching all that code.
>
> Also add an CONFIG_ARCH_HAS_DYNAMIC_NR_IRQS switch, define it in
> arch/x86/Kconfig and use it in include/linux/irq.h.
>
> This will create far less migration pain than the widespread rename.
> That will also solve the "what about the other architectures" question.

just send out v2.

long term, i hope to make all arch to use nr_irqs and probe it
earlier. and kill NR_IRQS

YH


\
 
 \ /
  Last update: 2008-07-30 12:19    [W:0.199 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site