Messages in this thread | | | Date | Thu, 3 Jul 2008 18:37:52 +0300 | From | "Pekka Enberg" <> | Subject | Re: slub: Do not use 192 byte sized cache if minimum alignment is 128 byte |
| |
On Thu, Jul 3, 2008 at 5:14 PM, Christoph Lameter <cl@linux-foundation.org> wrote: > The 192 byte cache is not necessary if we have a basic alignment of 128 > byte. If it would be used then the 192 would be aligned to the next 128 byte > boundary which would result in another 256 byte cache. Two 256 kmalloc caches > cause sysfs to complain about a duplicate entry. > > MIPS needs 128 byte aligned kmalloc caches and spits out warnings on boot without > this patch. > > Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Looks good to me. Yoichi, did you have the chance to test this? Christoph, are the warnings harmless or do we need to get this into 2.6.26?
| |