lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Request for documentation of PID handling functions
David Howells wrote:
> Hi Pavel,
>
> Can you please provide documentation for the PID handling functions you
> supplied in commit:
>
> 7af5729474b5b8ad385adadab78d6e723e7655a3
>
> In particular I'd like to know what locks are required when. I'm trying to
> determine if in this piece of code:
>
> read_lock(&tasklist_lock);
> ret = 0;
> if (pid != task_pid_vnr(current))
> ret = -EPERM;
> read_unlock(&tasklist_lock);
>
> the lock of tasklist_lock is necessary.

The RCU protection is enough to get pids from tasks. However, the pids
are detached under the tasklist lock write-locked, so provided you're
*already* sitting under it the RCU is excessive.

However, Oleg pointed me out some time ago, that in some cases RCU-only
protection was not enough in some cases, so I put him in Cc.

> David
>



\
 
 \ /
  Last update: 2008-07-30 04:07    [W:0.410 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site