lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [2.6 patch] remove CONFIG_IDE_MAX_HWIFS
Date
On Tuesday 29 July 2008, Adrian Bunk wrote:
> On Sun, Jul 27, 2008 at 04:32:16PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Sunday 27 July 2008, Adrian Bunk wrote:
> >...
> > > <-- snip -->
> > >
> > > Considering the little benefits of all this fiddling with IDE_MAX_HWIFS
> > > I decided to fix it through a simplification:
> > > - always #define MAX_HWIFS CONFIG_IDE_MAX_HWIFS
> > > - always set CONFIG_IDE_MAX_HWIFS in kconfig
> > > - let IDE_MAX_HWIFS default to 10
> > > - allow changing the value of IDE_MAX_HWIFS only if IDE && EMBEDDED
> >
> > I was actually wondering whether it is worth to keep IDE_MAX_HWIFS
> > now that ide_hwif_t instances are allocated dynamically.
> >
> > [ The difference between MAX_HWIFS == 10 and MAX_HWIFS == 2 is now
> > ~100 bytes (x86_32) and between MAX_HWIFS == 10 and MAX_HWIFS == 1
> > it is ~1kb (IIRC). ]
> >
> > Since there were also many other improvements in shrinking drivers/ide/
> > code size which should keep embedded users happy and compensate for
> > the above 1kB-worst-case I would prefer to have IDE_MAX_HWIFS removed
> > completely.
> >...
>
> Patch below.

applied

Thanks Adrian!


\
 
 \ /
  Last update: 2008-07-29 21:55    [W:0.037 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site