Messages in this thread | | | Date | Mon, 28 Jul 2008 23:20:52 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/24] x86: arch/x86/kernel/ cleanups |
| |
* Gustavo F. Padovan <gustavo@las.ic.unicamp.br> wrote:
> Ingo, > > I removed many extra whitespaces and tabs from arch/x86/kernel/
hm, we tend to do a full cleanup of files we touch for style cleanup.
You can check some style errors via:
scripts/checkpatch.pl --file arch/x86/kernel/alternative.c
but it also makes sense to look at the file and figure out places that look ugly.
> x86: kernel/alternative.c cleanup
total: 4 errors, 15 warnings, 4 checks, 540 lines checked
> x86: kernel/apm_32.c cleanup
total: 6 errors, 27 warnings, 5 checks, 2416 lines checked
[ etc. ]
If we did each style problem separately we'd be generating over 1 million commits for the entire tree - that's not feasible. So we go per file and once a file has been cleaned up, we keep it clean.
Note, checkpatch errors can be false positives occasionally, and not all warnings have to be fixed all the time - ask if unsure about whether to fix something or not.
It's also useful to check that the .o's are unchanged after a cleanup. You can see commits that do that, for example:
commit d4413732b54a17684e48fbb4b52fade5bf965b5d Author: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> Date: Tue Feb 19 23:51:27 2008 +0100
x86: coding style fixes to arch/x86/oprofile/op_model_athlon.c
The patch fixes 33 errors and a few warnings reported by checkpatch.pl
arch/x86/oprofile/op_model_athlon.o: text data bss dec hex filename 1691 0 32 1723 6bb op_model_athlon.o.before 1691 0 32 1723 6bb op_model_athlon.o.after md5: c354bc2d7140e1e626c03390eddaa0a6 op_model_athlon.o.before.asm c354bc2d7140e1e626c03390eddaa0a6 op_model_athlon.o.after.asm
Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Ingo
| |