Messages in this thread | | | Date | Mon, 28 Jul 2008 21:32:35 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] xen: xen: compile irq functions without -pg for ftrace |
| |
On Mon, Jul 28, 2008 at 11:53:57AM -0700, Jeremy Fitzhardinge wrote: > For some reason I managed to miss a bunch of irq-related functions > which also need to be compiled without -pg when using ftrace. This > patch moves them into their own file, and starts a cleanup process > I've been meaning to do anyway. > > [ Sam, Ingo: I think the problem was that I enabled CONFIG_FTRACE > but didn't do a clean build. Shouldn't the build-system notice > that the config changes the CFLAGS and rebuild everything? That > didn't seem to happen in this case. ]
The build system usually does this. And I have no reports that this has regressed until now. What file? Can you tell me how to reproduce it?
> > =================================================================== > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -2,9 +2,10 @@ > # Do not profile debug and lowlevel utilities > CFLAGS_REMOVE_spinlock.o = -pg > CFLAGS_REMOVE_time.o = -pg > +CFLAGS_REMOVE_irq.o = -pg > endif
I already NACK'ed this syntax and described the way it should be done. Is this ignored or on a TODO list?
Sam
| |