Messages in this thread | | | Date | Tue, 29 Jul 2008 04:07:49 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH] filldir write data missing size |
| |
On Tue, Jul 22, 2008 at 06:31:12AM +0900, OGAWA Hirofumi wrote: > Yoshinori Sato <ysato@users.sourceforge.jp> writes: > > > This problem is sh-linux-gcc v4.1.2 and target sh2(a)-bigendian. > > > > "__put_user(s64, u32_ptr)" compiled. > > > > Correct code. > > *u32_ptr = s64 & 0xffffffff; > > > > Bad code. > > *u32_ptr = s64 >> 32; > > > > I'm add cast put_user 4byte case. > > I see. How about the following patch? I guess the problems of this type > should be fixed. > I merged a different workaround as no one bothered to CC me on this thread. Your fix looks more correct though, please provide a Signed-off-by for it and I'll take this over the previous workaround.
| |