Messages in this thread | | | Date | Mon, 28 Jul 2008 08:53:46 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 1/1] mm: unify pmd_free() implementation |
| |
On Mon, 28 Jul 2008, Andrea Righi wrote: > > Move multiple definitions of pmd_free() from different include/asm-* into > mm/util.c.
But this is horrible, because it forces a totally unnecessary function call for that empty function.
Yeah, the function will be cheap, but the call itself will not be (it's a C language barrier and basically disables optimizations around it, causing thigns like register spill/reload for no good reason).
Linus
| |