[lkml]   [2008]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH v2] leds: make the default trigger name const
    The default_trigger fields of struct gpio_led and thus struct led_classdev
    are pretty much always assigned from a string literal, which means the
    string can't be modified. Which is fine, since there is no reason to
    modify the string and in fact it never is.

    But they should be marked const to prevent such code from being added, to
    prevent warnings if -Wwrite-strings is used and when assigned from a
    constant string other than a string literal (which produces a warning under
    current kernel compiler flags), and for general good coding practices.

    Signed-off-by: Trent Piepho <>
    include/linux/leds.h | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/include/linux/leds.h b/include/linux/leds.h
    index 519df72..defe693 100644
    --- a/include/linux/leds.h
    +++ b/include/linux/leds.h
    @@ -48,7 +48,7 @@ struct led_classdev {

    struct device *dev;
    struct list_head node; /* LED Device list */
    - char *default_trigger; /* Trigger to use */
    + const char *default_trigger; /* Trigger to use */

    /* Protects the trigger data below */
    @@ -121,7 +121,7 @@ extern void ledtrig_ide_activity(void);
    /* For the leds-gpio driver */
    struct gpio_led {
    const char *name;
    - char *default_trigger;
    + const char *default_trigger;
    unsigned gpio;
    u8 active_low;

     \ /
      Last update: 2008-07-28 04:09    [W:0.042 / U:0.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site