Messages in this thread | | | Date | Sat, 26 Jul 2008 09:15:28 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH 1/2] ftrace: single CPU tracers use CPU clock |
| |
On Sat, 26 Jul 2008, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@goodmis.org> wrote: > > > The current ftrace clock uses the sched_clock.c code. This code tries > > to handle cases where the TSC is out of sync between different CPUs. > > Unfortunately, even with insync TSCs, due to drifts between the CPU > > clock and the GTOD clock, we might get some inaccuracy in a single CPU > > trace. > >
[...]
> > this is not a good idea. We want to fix cpu_clock(), not work around any > deficiencies it might have.
cpu_clock currently is "sched_clock" when the CONFIG_HAVE_UNSTABLE_SCHED_CLOCK is not set. Which is done via configuration, and I noticed is set on my boxes with a stable TSC??
Perhaps we need to make cpu_clock change dynamically when an unstable sched_clock is detected.
Even in this case, forcing the tracers that are single CPU to use a clock source that modifies itself to try to look stable across CPUs still seems wrong to me. The goal of looking stable across CPUs will always be at odds with the irqsoff tracer that does not care about other CPUS but cares tremendously about accurate latencies.
-- Steve
| |