lkml.org 
[lkml]   [2008]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC,PATCH] scripts/package: add powerpc images to tarball
On Sat, Jul 26, 2008 at 1:20 PM, Milton Miller <miltonm@bga.com> wrote:
> On Jul 25, 2008, at 11:55 PM, Grant Likely wrote:
>>
>> On Thu, Jul 24, 2008 at 9:08 PM, Milton Miller <miltonm@bga.com> wrote:
>>>>
>>>> Add support for powerpc builds in the buildtar script, to include
>>>> a few default images.
>>>> ---
>>>> RFC: any requests for more/less boot images?
>>>
>>> ..
>>>>
>>>> + for img in zImage zImage.pseries zImage.iseries \
>>>> + dtbImage dtbImage.ps3
>>>
>>> Yes. How about all dtbImage, zImage, cuboot, treeboot, etc
>>> that are newer than vmlinux?
>>
>> dtbImage is not a buildable image. Neither is cuImage, treeImage or
>> simpleImage. All of those targets embed a device tree which is
>> specified by adding the .dts filename to the target name.
>
> I intended "all dtbImage" as a wildcard for dtbImage.*, etc.

Yeah, okay. That's a good idea.

>> so, for example, 'make cuImage' fails. Instead you do 'make
>> cuImage.lite5200b' which pulls in dts/lite5200b.dts.
>
> The user does make zImage which makes cuImage.lite5200b based on Kconfig.
> Or it was that way until your change in 2.6.25 to allow the later, but they
> can still do the former.

Yes, both methods should work (at least they both work for me). There
is also now a Kconfig option (CONFIG_EXTRA_TARGETS) which can be used
to add additional images to the zImage target list. Should be useful
for some of the defconfigs.

> Hmm, we really need to fix our calls to make boot images with make -j.
> Something for my todo list.

Good idea

>
>> Also, zImage is a 'meta' target that builds all the default image
>> targets (the $image-y list). The zImage is actually just a symlink to
>> the first file in the list of default images. So zImage can actually
>> point to any kind of kernel image depending on how the kernel is
>> configured. I wonder if we should just remove the zImage file
>> entirely, or at least make it always linked to one particular image
>> type.
>
> I think its fine as it is. It says "make what is configured" that lets
> cross-platform building scripts be dumb and not need to know specificially
> what image makes sense to make. Perhaps we should make it default to our
> additional target in Kconfig if specified, this allowing the user to specify
> which version he gets.

It makes sense if only one target is ever built at a time; but since
we build multiple targets, I don't want users to get caught just using
zImage and then get bitten when a a config or source change causes it
to be linked to a different kernel type.

Come to think of it, I'd support just removing the zImage symlink
entirely to eliminate confusion so that everyone knows that 'make
zImage' is the 'make all' for default image targets.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


\
 
 \ /
  Last update: 2008-07-26 19:57    [from the cache]
©2003-2011 Jasper Spaans