Messages in this thread | | | Date | Fri, 25 Jul 2008 11:39:43 +0300 | From | Adrian Bunk <> | Subject | PAGE_ALIGN() compile breakage |
| |
Commit 27ac792ca0b0a1e7e65f20342260650516c95864 (PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures) causes on some architectures (e.g. avr32 and mips) compile errors like the following in some configurations starting with:
<-- snip -->
... CC init/main.o In file included from /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/utsname.h:35, from /home/bunk/linux/kernel-2.6/git/linux-2.6/init/main.c:20: /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h: In function 'arch_pick_mmap_layout': /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h:2149: error: implicit declaration of function 'PAGE_ALIGN' make[2]: *** [init/main.o] Error 1
<-- snip -->
and more nasty problems follow later.
My suggestion is to: - revert commit 27ac792ca0b0a1e7e65f20342260650516c95864 and then - fix all PAGE_ALIGN() instances without moving them.
Unifying code is a good thing, but in this case it is not worth the trouble it causes by poking into the heart of our headers mess.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |