lkml.org 
[lkml]   [2008]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 1/9] hdlcdrv: Fix CRC calculation.
    2.6.25-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Micah Dowty <micah@navi.cx>

    [ Upstream commit ae6134bdf3197206fba95563d755d2fa50d90ddd ]

    This is a trivial patch against the hdlcdrv module that fixes its CRC
    calculation. The finished CRC was overwriting the first two bytes of
    each packet rather than being appended to the end.

    I've tested this with 2.6.8 and 2.6.10-rc1, but hdlcdrv hasn't changed
    much recently so it should work with many other kernel versions.

    Signed-off-by: Micah Dowty <micah@navi.cx>
    Acked-by: Thomas Sailer <t.sailer@alumni.ethz.ch>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/hamradio/hdlcdrv.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/hamradio/hdlcdrv.c
    +++ b/drivers/net/hamradio/hdlcdrv.c
    @@ -88,6 +88,7 @@
    static inline void append_crc_ccitt(unsigned char *buffer, int len)
    {
    unsigned int crc = crc_ccitt(0xffff, buffer, len) ^ 0xffff;
    + buffer += len;
    *buffer++ = crc;
    *buffer++ = crc >> 8;
    }
    --


    \
     
     \ /
      Last update: 2008-07-26 01:13    [W:3.433 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site