lkml.org 
[lkml]   [2008]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/4] of: adapt of_find_i2c_driver() to be usable by SPI also
On Fri, Jul 25, 2008 at 1:02 PM, Jon Smirl <jonsmirl@gmail.com> wrote:
> On 7/25/08, Grant Likely <grant.likely@secretlab.ca> wrote:
>> On Fri, Jul 25, 2008 at 11:40 AM, Jon Smirl <jonsmirl@gmail.com> wrote:
>> > On 7/25/08, Grant Likely <grant.likely@secretlab.ca> wrote:
>> >> + * First method is to lookup the compatible value in of_modalias_table.
>> >> + * Second is to look for a "linux,<modalias>" entry in the compatible list
>> >> + * and used that for modalias. Third is to strip off the manufacturer
>> >> + * prefix from the first compatible entry and use the remainder as modalias
>> >
>> > I also think this is a problem. Embedding the name of Linux device
>> > drivers into device firmware makes it almost impossible to rename the
>> > device driver. Again, what is a case where generic part numbers can't
>> > be listed in the alias section of the linux device driver?
>> >
>> > Even eeprom was just fixed to take generic part numbers (at24).
>>
>> Again, I agree, but this change is very much a stop gap measure to get
>> things working in a sane way without having to create bad device tree
>> bindings (device tree bindings are hard to change, code is not). I've
>> been considering posting a patch to remove this clause from the
>> functions, but that needs to be reviewed separately from this change.
>
> Isn't putting "compatible="linux,modalias"" into your device tree a
> really bad idea?

Yes, it is, but I still need to preserve existing behavior in this
patch. That change needs to be reviewed separately. I'll submit
another patch to deal with this.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


\
 
 \ /
  Last update: 2008-07-25 20:55    [W:0.079 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site