lkml.org 
[lkml]   [2008]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized
Hello Dmitry,
>
> Thank you for the changes. You don't have to track whether device is
> manually suspended or not - usb_submit_urb will fail and that is it.
>

Perfect.

> Attached are 2 patches. First cleans suspend state tracking as it is not
> really needed and does some formatting and other minor changes and 2nd
> implements runtime pm for the device. Could you please try them and if
> everything still works I will apply the driver.

Patch 1:

Looking good, just a few comments:

* I notice that clamp_val is new since 2.6.24.3
* Regarding the open-fails comment: is EACCES correct?

Patch 2:

Perfect.

Thank you so much, Dmitry - it's a GO!

Henrik



\
 
 \ /
  Last update: 2008-07-25 20:29    [W:0.041 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site