Messages in this thread | | | Date | Thu, 24 Jul 2008 11:59:03 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [patch] x64, fpu: fix possible FPU leakage in error conditions |
| |
On Thu, 24 Jul 2008, Suresh Siddha wrote: > > If we don't do init_fpu() + restore from the sane init state, process has > to be killed, in the paranoid failing scenario of math_state_restore()
Umm. I'm still not seeing why the right answer is not just to do "stts + math_used = 0".
And the specific case of math_state_restore(), that will also fix the problem - next time around.
As far as I can tell, your patch causes serious problems in case init_fpu() fails. Which it can do, afaik.
Linus
| |