lkml.org 
[lkml]   [2008]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x64, fpu: fix possible FPU leakage in error conditions


On Thu, 24 Jul 2008, Suresh Siddha wrote:
>
> If we don't do init_fpu() + restore from the sane init state, process has
> to be killed, in the paranoid failing scenario of math_state_restore()

Umm. I'm still not seeing why the right answer is not just to do "stts +
math_used = 0".

And the specific case of math_state_restore(), that will also fix the
problem - next time around.

As far as I can tell, your patch causes serious problems in case
init_fpu() fails. Which it can do, afaik.

Linus


\
 
 \ /
  Last update: 2008-07-24 21:05    [W:0.047 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site