lkml.org 
[lkml]   [2008]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open()
    Jeremy Fitzhardinge wrote:
    > Eduardo Habkost wrote:
    >> xen-netfront was waking the queue before calling netif_start_queue(),
    >> triggering the BUG_ON() on __netif_schedule().
    >>
    >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    >>
    > Ok,
    > Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    >
    > but Ingo, do you want to pick this up? You're gathering a collection of
    > these patches anyway, or should we kick it over to Dave/Jeff?
    >
    > J
    >
    >> ---
    >> drivers/net/xen-netfront.c | 2 +-
    >> 1 files changed, 1 insertions(+), 1 deletions(-)
    >>
    >> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
    >> index 902bbe7..c749bdb 100644
    >> --- a/drivers/net/xen-netfront.c
    >> +++ b/drivers/net/xen-netfront.c
    >> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
    >> }
    >> spin_unlock_bh(&np->rx_lock);
    >>
    >> - xennet_maybe_wake_tx(dev);
    >> + netif_start_queue(dev);

    This is clearly a net driver change, it should go this way...

    Jeff





    \
     
     \ /
      Last update: 2008-07-24 20:33    [W:0.034 / U:0.584 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site