Messages in this thread | | | Date | Fri, 25 Jul 2008 01:27:48 +0900 (JST) | Subject | Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core | From | Atsushi Nemoto <> |
| |
On Fri, 18 Jul 2008 12:08:47 -0500, Jason Wessel <jason.wessel@windriver.com> wrote: > diff --git a/include/asm-mips/kgdb.h b/include/asm-mips/kgdb.h ... > +static inline void arch_kgdb_breakpoint(void) > +{ > + __asm__ __volatile__( > + ".globl breakinst\n\t" > + ".set\tnoreorder\n\t" > + "nop\n" > + "breakinst:\tbreak\n\t" > + "nop\n\t" > + ".set\treorder"); > +}
The gcc might inline kgdb_breakpoint() which includes arch_kgdb_breakpoint(). I got this error with gcc 4.3.1:
CC kernel/kgdb.o {standard input}: Assembler messages: {standard input}:809: Error: symbol `breakinst' is already defined {standard input}:913: Error: symbol `breakinst' is already defined {standard input}:1233: Error: symbol `breakinst' is already defined
Moving arch_kgdb_breakpoint() into arch/mips/kernel/kgdb.c should solve the problem.
--- Atsushi Nemoto
| |