lkml.org 
[lkml]   [2008]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 08/17] LTTng instrumentation - kernel

    On Thu, 24 Jul 2008, Mathieu Desnoyers wrote:
    >
    > * Steven Rostedt (rostedt@goodmis.org) wrote:
    > >
    > >
    > > On Tue, 15 Jul 2008, Mathieu Desnoyers wrote:
    > > >
    > > > /*
    > > > * Low level drivers may need that to know if they can schedule in
    > > > @@ -601,6 +603,7 @@ asmlinkage int printk(const char *fmt, .
    > > > int r;
    > > >
    > > > va_start(args, fmt);
    > > > + trace_kernel_printk(__builtin_return_address(0));
    > >
    > > BTW, ftrace.h has macros that let you use CALLER_ADDR0 for
    > > __builtin_return_address. It also converts it from a pointer to a long,
    > > but makes the code look prettier.
    > >
    >
    > include/linux/kernel.h:#define _RET_IP_ (unsigned long)__builtin_return_address(0)
    >
    > Hrm, did not see this one. So I guess we can both switch to it ?

    Hmm, yeah, I forgot about that. Someplaces I do use CALLER_ADDR1 and
    higher, but when it is just CALLER_ADDR0, then _RET_IP_ would probably be
    better.

    >
    > Thanks for pointing this out,

    -- Steve



    \
     
     \ /
      Last update: 2008-07-24 17:17    [W:0.021 / U:61.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site