lkml.org 
[lkml]   [2008]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map
    Hi,

    On Wed, Jul 23, 2008 at 19:18, Mike Travis <travis@sgi.com> wrote:
    > --- linux-2.6.tip.orig/arch/x86/kernel/setup_percpu.c
    > +++ linux-2.6.tip/arch/x86/kernel/setup_percpu.c
    > @@ -80,8 +80,15 @@ static void __init setup_per_cpu_maps(vo
    > #endif
    > }
    >
    > -#ifdef CONFIG_HAVE_CPUMASK_OF_CPU_MAP
    > -cpumask_t *cpumask_of_cpu_map __read_mostly;
    > +#ifdef CONFIG_HAVE_CPUMASK_OF_CPU_MAP_PTR
    > +/*
    > + * Configure an initial cpumask_of_cpu(0) for early users
    > + */
    > +static cpumask_t initial_cpumask_of_cpu_map __initdata = (cpumask_t) { {
    > + [BITS_TO_LONGS(NR_CPUS)-1] = 1
    > +} };
    This looks weird, first one missing {} pair, which may explain Ingo's
    build error. Second, why do you want to set the last unsigned long to
    one? Shouldn't this be the first?

    Regards
    Bert


    > +cpumask_t *cpumask_of_cpu_map __read_mostly =
    > + (cpumask_t *)&initial_cpumask_of_cpu_map;
    > EXPORT_SYMBOL(cpumask_of_cpu_map);
    >


    \
     
     \ /
      Last update: 2008-07-24 14:59    [W:4.035 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site