lkml.org 
[lkml]   [2008]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: GRU driver feedback
On Wed, Jul 23, 2008 at 04:12:30PM +0200, Nick Piggin wrote:
>
> Hi Jack,
>
> Some review of the GRU driver. Hope it helps. Some trivial.

Thanks for the feedback. I'm at OLS this week & barely reading email.
I'll go thru the comments as soon as I get home next week & will
respond in detail then.


>
> - I would put all the driver into a single patch. It's a logical change,
> and splitting them out is not really logical. Unless for example you
> start with a minimally functional driver and build more things on it,
> I don't think there is any point avoiding the one big patch. You have to
> look at the whole thing to understand it properly anyway really.

I would prefer that, too, but was told by one of the more verbose
kernel developers (who will remain nameless) that I should split the code
into multiple patches to make it easier to review. Oh well.....


More responses to follow....


--- jack



\
 
 \ /
  Last update: 2008-07-24 05:29    [W:0.393 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site