| From | Greg Kroah-Hartman <> | Subject | [PATCH 61/79] kobject: should use kobject_put() in kset-example | Date | Mon, 21 Jul 2008 22:19:25 -0700 |
| |
From: Li Zefan <lizf@cn.fujitsu.com>
We should call kobject_put() instead of kfree() if kobject_init_and_add() returns an error, shouldn't we? Don't set up a bad example ;)
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- samples/kobject/kset-example.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c index b0a1b4f..7395c0b 100644 --- a/samples/kobject/kset-example.c +++ b/samples/kobject/kset-example.c @@ -211,7 +211,7 @@ static struct foo_obj *create_foo_obj(const char *name) */ retval = kobject_init_and_add(&foo->kobj, &foo_ktype, NULL, "%s", name); if (retval) { - kfree(foo); + kobject_put(&foo->kobj); return NULL; } -- 1.5.6.3
|