lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver
    On Fri, Jul 18, 2008 at 2:51 PM, Brice Goglin <Brice.Goglin@inria.fr> wrote:
    > Dan Williams wrote:
    >>>> Sleep time in self_test has been increased to 10ms
    >>>> since in some cases 1ms appeared not to be enough
    >>> Thanks Maciej, this helps a lot here.
    >>>
    >>
    >> Can I interpret this as a "Tested-by" for the watchdog and/or the self_test fix?
    >
    > The sleep time increase to 10ms has been tested for a while (and helps a
    > lot here).
    >

    On my system I can still occasionally reproduce the self-test failure
    with this longer timeout. I think we should hold off on this band-aid
    patch until the root cause is found. We can get this fix in after the
    merge window closes.

    > I don't know about the watchdog yet.

    This one has been observed to fix the hang condition so I will include
    it in my upcoming pull request. Holler if your testing proves
    otherwise.

    Thanks,
    Dan


    \
     
     \ /
      Last update: 2008-07-23 01:39    [W:2.938 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site