lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 15/47] b43legacy: Fix possible NULL pointer dereference in DMA code
    2.6.25-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------
    From: Michael Buesch <mb@bu3sch.de>

    commit 2f9ec47d0954f9d2e5a00209c2689cbc477a8c89 upstream

    This fixes a possible NULL pointer dereference in an error path of the
    DMA allocation error checking code. This is also necessary for a future
    DMA API change that is on its way into the mainline kernel that adds
    an additional dev parameter to dma_mapping_error().

    Signed-off-by: Michael Buesch <mb@bu3sch.de>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/wireless/b43legacy/dma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/b43legacy/dma.c
    +++ b/drivers/net/wireless/b43legacy/dma.c
    @@ -876,6 +876,7 @@ struct b43legacy_dmaring *b43legacy_setu
    if (!ring)
    goto out;
    ring->type = type;
    + ring->dev = dev;

    nr_slots = B43legacy_RXRING_SLOTS;
    if (for_tx)
    @@ -922,7 +923,6 @@ struct b43legacy_dmaring *b43legacy_setu
    DMA_TO_DEVICE);
    }

    - ring->dev = dev;
    ring->nr_slots = nr_slots;
    ring->mmio_base = b43legacy_dmacontroller_base(type, controller_index);
    ring->index = controller_index;
    --


    \
     
     \ /
      Last update: 2008-07-23 01:25    [W:0.022 / U:2.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site