lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 02/79] kobject: replace '/' with '!' in name
    Date
    Hi Greg,
    hi Kay,

    On Tuesday 22 July 2008, Greg Kroah-Hartman wrote:
    > From: Kay Sievers <kay.sievers@vrfy.org>
    >
    > Some (block) devices have a '/' in the name, and need special
    > handling. Let's have that rule to the core, so we can remove it
    > from the block class.

    Yes, but why replace only one?

    > diff --git a/lib/kobject.c b/lib/kobject.c
    > index dcade05..7444015 100644
    > --- a/lib/kobject.c
    > +++ b/lib/kobject.c
    > @@ -216,13 +216,19 @@ static int kobject_add_internal(struct kobject *kobj)
    > static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
    > va_list vargs)
    > {
    > - /* Free the old name, if necessary. */
    > - kfree(kobj->name);
    > + const char *old_name = kobj->name;
    > + char *s;
    >
    > kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
    > if (!kobj->name)
    > return -ENOMEM;
    >
    > + /* ewww... some of these buggers have '/' in the name ... */
    > + s = strchr(kobj->name, '/');
    > + if (s)
    > + s[0] = '!';
    > +
    > + kfree(old_name);
    > return 0;
    > }

    while (s = strchr(kobj->name, '/')) {
    s[0] = '!';
    }

    instead?


    Best Regards

    Ingo Oeser


    \
     
     \ /
      Last update: 2008-07-22 20:31    [W:3.842 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site