Messages in this thread | | | Date | Tue, 22 Jul 2008 16:46:41 +0200 | From | "Michael Kerrisk" <> | Subject | Re: [PATCH -mm] coredump: format_corename: don't append .%pid if multi-threaded |
| |
On Tue, Jul 22, 2008 at 3:02 PM, Oleg Nesterov <oleg@tv-sign.ru> wrote: > On 07/22, Michael Kerrisk wrote: >> >> On Tue, Jul 22, 2008 at 2:43 PM, Oleg Nesterov <oleg@tv-sign.ru> wrote: >> > >> > That said, this is the user-visible change... >> >> True. Not sure how important that is in this case though. What is >> the reason for making this change (other than tidiness)? > > Tidiness is the only reason. > > Please don't hesitate to nack this patch if you think we shouldn't > change the historical behaviour, the cleanup is very minor.
It is hard to think of something that might break because of this, so I'll remain silent.
> As for me, I think it is a bit strange we append "%.pid" depending on > is_multithreaded, the same app can have 1 or more threads for various
Agreed. It is strange.
Cheers,
Michael
> reasons when the coredump happens, but this behaviour is very old and > perhaps it is too late to change. > > Oleg. > >
-- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
| |