Messages in this thread | | | Date | Tue, 22 Jul 2008 17:02:06 +0400 | From | Oleg Nesterov <> | Subject | Re: [PATCH -mm] coredump: format_corename: don't append .%pid if multi-threaded |
| |
On 07/22, Michael Kerrisk wrote: > > On Tue, Jul 22, 2008 at 2:43 PM, Oleg Nesterov <oleg@tv-sign.ru> wrote: > > > > That said, this is the user-visible change... > > True. Not sure how important that is in this case though. What is > the reason for making this change (other than tidiness)?
Tidiness is the only reason.
Please don't hesitate to nack this patch if you think we shouldn't change the historical behaviour, the cleanup is very minor.
As for me, I think it is a bit strange we append "%.pid" depending on is_multithreaded, the same app can have 1 or more threads for various reasons when the coredump happens, but this behaviour is very old and perhaps it is too late to change.
Oleg.
| |