lkml.org 
[lkml]   [2008]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [GIT]: Networking
    From
    From: Linus Torvalds <torvalds@linux-foundation.org>
    Date: Mon, 21 Jul 2008 09:49:49 -0700 (PDT)

    > Why is it so unnecessarily fragile to begin with? Especially for stuff
    > that happens at bootup or suspend, doing a BUG_ON() is _particularly_
    > painful, because a dead machine means that you cannot get any logs or
    > anything else.

    I agree, the BUG_ON() was the wrong way to go.

    > So wouldn't it be *much* better to do something like the appended, and at
    > least try to limp on, and maybe have a system that people can get logs
    > out of?

    Agreed, I'll apply this. Thanks.

    > diff --git a/net/core/dev.c b/net/core/dev.c
    > index 2eed17b..43ab4f5 100644
    > --- a/net/core/dev.c
    > +++ b/net/core/dev.c
    > @@ -1325,7 +1325,8 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
    >
    > void __netif_schedule(struct Qdisc *q)
    > {
    > - BUG_ON(q == &noop_qdisc);
    > + if (WARN_ON_ONCE(q == &noop_qdisc))
    > + return;
    >
    > if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state)) {
    > struct softnet_data *sd;
    > ---


    \
     
     \ /
      Last update: 2008-07-21 18:55    [W:4.533 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site