lkml.org 
[lkml]   [2008]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2.6.26-mmotm] rtc: BCD codeshrink
On Wed, Jul 02, 2008 at 01:45:02AM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2008 23:41:01 -0700 David Brownell <david-b@pacbell.net> wrote:
>
> > This updates <linux/bcd.h> to define the key routines as constant
> > functions, which the macros will then call. Newer code can now
> > call bcd2bin() instead of SCREAMING BCD2BIN() TO THE FOUR WINDS.
> >
> > This lets each driver shrink their codespace by using N function
> > calls to a single (global) copy of those routines, instead of N
> > inlined copies of these functions per driver.
> >
> > These routines aren't used in speed-critical code. Almost all
> > callers are in the RTC framework. Typical per-driver savings is
> > near 300 bytes.
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> > Acked-by: Adrian Bunk <bunk@kernel.org>
> > ---
> > include/linux/bcd.h | 9 +++++++--
> > lib/Makefile | 2 +-
> > lib/bcd.c | 14 ++++++++++++++
> > 3 files changed, 22 insertions(+), 3 deletions(-)
> >
> > --- a/include/linux/bcd.h 2008-06-30 16:44:26.000000000 -0700
> > +++ b/include/linux/bcd.h 2008-06-30 21:38:24.000000000 -0700
> > @@ -10,8 +10,13 @@
> > #ifndef _BCD_H
> > #define _BCD_H
> >
> > -#define BCD2BIN(val) (((val) & 0x0f) + ((val)>>4)*10)
> > -#define BIN2BCD(val) ((((val)/10)<<4) + (val)%10)
> > +#include <linux/compiler.h>
> > +
> > +unsigned bcd2bin(unsigned char val) __attribute_const__;
> > +unsigned char bin2bcd(unsigned val) __attribute_const__;
> > +
> > +#define BCD2BIN(val) bcd2bin(val)
> > +#define BIN2BCD(val) bin2bcd(val)
>
> It'd be good to nuke these things now.
>...

Unless David is faster I plan to do this after the patch went into
Linus' tree.

E.g. rtc-ramtron-fm3130-rtc-support.patch in 2.6.26-rc5-mm3 adds a new
user, and it should create less hassle if the actual removal of the
#define's happens around 2.6.27-rc1 when everything is merged into
Linus' tree.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-07-02 10:59    [W:0.033 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site