Messages in this thread | | | Date | Wed, 2 Jul 2008 20:40:38 +0400 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/2] workqueues: make get_online_cpus() useable for work->func() |
| |
On 07/02, Andrew Morton wrote: > > I know that Document/SubmitChecklist has a lot of stuff. But a basic > allnoconfig only takes seconds and it's often the thing which breaks. > > include/linux/cpu.h | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff -puN include/linux/cpu.h~workqueues-make-get_online_cpus-useable-for-work-func-fix include/linux/cpu.h > --- a/include/linux/cpu.h~workqueues-make-get_online_cpus-useable-for-work-func-fix > +++ a/include/linux/cpu.h > @@ -69,10 +69,11 @@ static inline void unregister_cpu_notifi > #endif > > int cpu_up(unsigned int cpu); > - > extern void cpu_hotplug_init(void); > +extern void cpu_maps_update_begin(void); > +extern void cpu_maps_update_done(void); > > -#else > +#else /* CONFIG_SMP */ > > static inline int register_cpu_notifier(struct notifier_block *nb) > { > @@ -87,10 +88,16 @@ static inline void cpu_hotplug_init(void > { > } > > +static inline void cpu_maps_update_begin(void) > +{ > +} > + > +static inline void cpu_maps_update_done(void) > +{ > +}
Oh thanks...
This also means that we can't kill workqueue_lock (as I was going to do), we still need it for !CONFIG_HOTPLUG_CPU case.
Oleg.
| |