lkml.org 
[lkml]   [2008]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] vfs: use kstrdup()
    [Li Zefan - Sat, Jul 19, 2008 at 06:16:20PM +0800]
    | This piece of code can be replaced by a kstrdup().
    |
    | Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    | ---
    | fs/namespace.c | 9 +--------
    | 1 files changed, 1 insertions(+), 8 deletions(-)
    |
    | diff --git a/fs/namespace.c b/fs/namespace.c
    | index 4f6f763..08c3b2d 100644
    | --- a/fs/namespace.c
    | +++ b/fs/namespace.c
    | @@ -127,14 +127,7 @@ struct vfsmount *alloc_vfsmnt(const char *name)
    | INIT_LIST_HEAD(&mnt->mnt_slave_list);
    | INIT_LIST_HEAD(&mnt->mnt_slave);
    | atomic_set(&mnt->__mnt_writers, 0);
    | - if (name) {
    | - int size = strlen(name) + 1;
    | - char *newname = kmalloc(size, GFP_KERNEL);
    | - if (newname) {
    | - memcpy(newname, name, size);
    | - mnt->mnt_devname = newname;
    | - }
    | - }
    | + mnt->mnt_devname = kstrdup(name, GFP_KERNEL);
    | }
    | return mnt;
    | }
    | --
    | 1.5.4.rc3
    |
    |

    but kstrdup may return NULL - is it safe there?
    Sorry if that "not smart" question.

    - Cyrill -


    \
     
     \ /
      Last update: 2008-07-19 15:15    [W:0.026 / U:0.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site