Messages in this thread | | | Date | Mon, 14 Jul 2008 20:50:57 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] block: fix block_class iteration locking |
| |
Cornelia Huck wrote: > Greg has some patches sitting in his tree that convert those functions > to use class_{for_each,find}_device() instead - and that looks like the > clean solution, especially since the class implementation details will > be moved into a private structure. One worry though...
Yeah, that sounds nice.
> With your patch, you protect against adding/removing devices to/from > the class between _start and _stop. This wasn't done previously, and > won't be done with Greg's patches (which leaves in the > locking/unlocking of block_class_lock). Not sure if I'm missing > something here...
That's mostly the point of this patch. It wasn't protected properly before. It would be best if there's a safe iterator (maybe use klist?).
Thanks.
-- tejun
| |