Messages in this thread | | | Date | Sat, 19 Jul 2008 23:43:29 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives |
| |
* Zachary Amsden <zach@vmware.com> wrote:
> On Fri, 2008-07-18 at 15:49 -0700, Suresh Siddha wrote: > > > > Thank you for cleaning this up Yinghai, but this really begs the > > > question - is having write_atomic REALLY worthwhile? > > > > And this thread is about, Maciej's cleanup patch which removed > > write_atomic completely :) > > > > Thanks to Maciej who posted this fix. It was on my todo list for > > sometime now! > > Awesome! I just felt the need to use 'flaming crap' in a sentence > today, and broken APICs seemed like an easy target. Glad to know it's > gone.
it's gone, but without breaking or limiting old hardware: it's done by moving the code into a quirk. And that's the general direction which we want to take in such cases - move ugly non-standard stuff into low-maintenance-overhead quirks.
Ingo
| |