Messages in this thread | | | Date | Sat, 19 Jul 2008 00:32:29 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH ftrace.git] Immedate Values Optimized Jump Fix |
| |
* Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote:
> * Ingo Molnar (mingo@elte.hu) wrote: > > > > * Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote: > > > > > Hi Ingo, > > > > > > This fix would apply to the ftrace tree which contains the jump-based > > > immediate values. I don't know if this tree is still under active > > > development, but I guess that it wouldn't hurt to fix it. > > > > > > Caused a kernel OOPS when loading the tracepoint probes once in a > > > while on a 8-way x86_64. > > > > We've still got tip/tracing/immediates, with these commits from you: > > > > $ git-log-line linus.. arch/x86/kernel/immediate.c > > ee563d6: immediate values: jump liveliness > > e26875a: Immediate Values - Jump > > 3fc8d03: Immediate Values - x86 Optimization NMI and MCE support > > > > ... but the topic is stalled right now, due to hpa having had > > objections. Have those concerns been resolved? (Peter Cc:-ed) > > > > i'd have applied this fix, but it does not apply. The first chunk seems > > already be present (in a different form), the second chunk looks much > > different. > > > > Ingo > > > > Hrm, I've edited directly the immediate values: jump liveliness patches, > which explains why it does not apply. I'll try to unapply/reapply/fold > the patches and see what it gives. > > Plus, I've noticed that the "Text Edit Lock" patches are not in the > immediates branch, thus it fails to compile. Immediate values depends > on the Text Edit Lock patches.
feel free to git-cherry-pick the commits together into a coherent unit (preferrably all -git based), and we can give it a whirl in tip/master.
Ingo
| |