Messages in this thread Patch in this message | | | Date | Fri, 18 Jul 2008 13:47:45 +0100 | From | "Jan Beulich" <> | Subject | [PATCH] x86: clean up pgd_{c,d}tor |
| |
Giving pgd_ctor() a properly typed parameter allows eliminating a local variable. Adjust pgd_dtor() to match.
Also, pgd_ctor()'s clearing of the memory is redundant with the GFP_ZERO used for allocating it.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- arch/x86/mm/pgtable.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
--- linux-2.6.26/arch/x86/mm/pgtable.c 2008-07-13 23:51:29.000000000 +0200 +++ 2.6.26-x86-pgd-alloc-cleanup/arch/x86/mm/pgtable.c 2008-06-25 14:35:40.000000000 +0200 @@ -62,14 +62,10 @@ static inline void pgd_list_del(pgd_t *p #define UNSHARED_PTRS_PER_PGD \ (SHARED_KERNEL_PMD ? KERNEL_PGD_BOUNDARY : PTRS_PER_PGD) -static void pgd_ctor(void *p) +static void pgd_ctor(pgd_t *pgd) { - pgd_t *pgd = p; unsigned long flags; - /* Clear usermode parts of PGD */ - memset(pgd, 0, KERNEL_PGD_BOUNDARY*sizeof(pgd_t)); - spin_lock_irqsave(&pgd_lock, flags); /* If the pgd points to a shared pagetable level (either the @@ -94,7 +90,7 @@ static void pgd_ctor(void *p) spin_unlock_irqrestore(&pgd_lock, flags); } -static void pgd_dtor(void *pgd) +static void pgd_dtor(pgd_t *pgd) { unsigned long flags; /* can be called from interrupt context */
| |