Messages in this thread | | | Date | Thu, 17 Jul 2008 09:34:26 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 01/23] tracehook: add linux/tracehook.h |
| |
On Thu, Jul 17, 2008 at 12:48:18PM +0400, Alexey Dobriyan wrote: > > The new linux/ptrace.h inlines are used by the following patches in the > > new tracehook_*() inlines. Using these helpers for the ptrace event > > stops makes it simple to change or disable the old ptrace implementation > > of these stops conditionally later. > > Call them "utrace_*" from the start?
Yes, please.
> Pointless 1:1 wrapper unless you're going to #ifdef ->ptrace later.
Even then I don't think it's a good idea. This one should only be touched in very very few places
| |